Skip to content

Conversation

cabljac
Copy link
Collaborator

@cabljac cabljac commented Sep 25, 2025

supercedes #225

@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 10:26
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: 263044b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack-query-firebase/angular Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

docs-page bot commented Sep 25, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~226

Documentation is deployed and generated using docs.page.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Angular v20 by updating package dependencies and replacing deprecated Angular APIs with their stable equivalents.

  • Updates Angular dependencies to support both v19 and v20 versions using semver ranges
  • Replaces deprecated provideExperimentalZonelessChangeDetection with stable provideZonelessChangeDetection API
  • Reorganizes generated SDK code structure in data connect files

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/angular/src/data-connect/injectDataConnectQuery.test.ts Updates import and usage of zoneless change detection provider
packages/angular/src/data-connect/injectDataConnectMutation.test.ts Updates import and usage of zoneless change detection provider
packages/angular/package.json Updates peer dependencies to support Angular v20 alongside v19
package.json Updates root dependencies to Angular v20 and Firebase v20
dataconnect-sdk/js/default-connector/package.json Adds Firebase v12 support to peer dependencies
dataconnect-sdk/js/default-connector/index.cjs.js Reorganizes code structure by moving query functions before mutation functions
dataconnect-sdk/js/default-connector/esm/index.esm.js Reorganizes code structure by moving query functions before mutation functions
.changeset/beige-months-allow.md Adds changeset documentation for the Angular v20 support feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Summary of Changes

Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for Angular v20, ensuring compatibility with the latest Angular ecosystem. It involves upgrading core Angular and Firebase dependencies, adapting to the stable provideZonelessChangeDetection API, and includes minor refactoring of data connect operation exports for improved code structure.

Highlights

  • Angular v20 Support: The project now officially supports Angular v20, with updated dependencies across various package.json files to ensure compatibility with the latest Angular ecosystem.
  • Dependency Updates: Key Angular and Firebase dependencies have been upgraded to their latest major versions, including @angular/core, @angular/fire, and the firebase peer dependency.
  • Zoneless Change Detection API: The provideExperimentalZonelessChangeDetection API has been updated to its stable counterpart, provideZonelessChangeDetection, reflecting changes introduced in Angular v20.
  • Data Connect Operations Reordering: Several data connect query and mutation operations (listMovies, getMovieById, getMeta) were reordered within their respective files for better organization and consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cabljac cabljac mentioned this pull request Sep 25, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on adding support for Angular v20 by updating relevant dependencies across the project. The changes include upgrading @angular/core and @angular/fire to their v20 counterparts, adjusting peer dependencies to be compatible with both Angular v19 and v20, and replacing the deprecated provideExperimentalZonelessChangeDetection with the stable provideZonelessChangeDetection API in test files. Additionally, there are some code reordering changes in the DataConnect SDK files, likely for consistency, and an update to the firebase peer dependency to include v12. Overall, the changes are well-aligned with the goal of supporting Angular v20. I have one suggestion regarding the @tanstack/angular-query-experimental dependency versioning for better consistency.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 11 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • packages/react/package-lock.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved [PR]
Development

Successfully merging this pull request may close these issues.

3 participants