-
Notifications
You must be signed in to change notification settings - Fork 75
feat: add angular v20 support #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 263044b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~226 Documentation is deployed and generated using docs.page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Angular v20 by updating package dependencies and replacing deprecated Angular APIs with their stable equivalents.
- Updates Angular dependencies to support both v19 and v20 versions using semver ranges
- Replaces deprecated
provideExperimentalZonelessChangeDetection
with stableprovideZonelessChangeDetection
API - Reorganizes generated SDK code structure in data connect files
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/angular/src/data-connect/injectDataConnectQuery.test.ts | Updates import and usage of zoneless change detection provider |
packages/angular/src/data-connect/injectDataConnectMutation.test.ts | Updates import and usage of zoneless change detection provider |
packages/angular/package.json | Updates peer dependencies to support Angular v20 alongside v19 |
package.json | Updates root dependencies to Angular v20 and Firebase v20 |
dataconnect-sdk/js/default-connector/package.json | Adds Firebase v12 support to peer dependencies |
dataconnect-sdk/js/default-connector/index.cjs.js | Reorganizes code structure by moving query functions before mutation functions |
dataconnect-sdk/js/default-connector/esm/index.esm.js | Reorganizes code structure by moving query functions before mutation functions |
.changeset/beige-months-allow.md | Adds changeset documentation for the Angular v20 support feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for Angular v20, ensuring compatibility with the latest Angular ecosystem. It involves upgrading core Angular and Firebase dependencies, adapting to the stable Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on adding support for Angular v20 by updating relevant dependencies across the project. The changes include upgrading @angular/core
and @angular/fire
to their v20 counterparts, adjusting peer dependencies to be compatible with both Angular v19 and v20, and replacing the deprecated provideExperimentalZonelessChangeDetection
with the stable provideZonelessChangeDetection
API in test files. Additionally, there are some code reordering changes in the DataConnect SDK files, likely for consistency, and an update to the firebase
peer dependency to include v12. Overall, the changes are well-aligned with the goal of supporting Angular v20. I have one suggestion regarding the @tanstack/angular-query-experimental
dependency versioning for better consistency.
aee769d
to
263044b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 11 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- packages/react/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
supercedes #225