Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for waypoints #172

Merged
merged 15 commits into from
Jan 19, 2024
Merged

Adding support for waypoints #172

merged 15 commits into from
Jan 19, 2024

Conversation

Ruishenl
Copy link
Collaborator

No description provided.

@Ruishenl Ruishenl requested a review from rf-ivtdai January 18, 2024 19:01
@rf-ivtdai
Copy link
Collaborator

rf-ivtdai commented Jan 18, 2024

Looks good. Could you please add cpp test flows to visualize:

  • Multi-agent waypoints. 2 cars and 2 pedestrians with their own waypoints, potentially having trajectories crossing each other. We currently only care about system validity (feature runs as expected), and not model quality (whether agents wait for each other gracefully).
  • Multi-agent waypoint through red lights.

Please update the general descriptions of agent_attributes for drive() and initialize():

  • invertedai/api/drive.py
  • invertedai/api/initialize.py

@Ruishenl
Copy link
Collaborator Author

Looks good. Could you please add cpp test flows to visualize:

  • Multi-agent waypoints. 2 cars and 2 pedestrians with their own waypoints, potentially having trajectories crossing each other. We currently only care about system validity (feature runs as expected), and not model quality (whether agents wait for each other gracefully).
  • Multi-agent waypoint through red lights.

Please update the general descriptions of agent_attributes for drive() and initialize():

  • invertedai/api/drive.py
  • invertedai/api/initialize.py

I added a single misslilenous test flow for multi agent type with waypoints with traffic lights

@Ruishenl Ruishenl merged commit e843497 into develop Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants