Log replay #215
Log replay #215
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
invertedai/logs/common.py
Outdated
| json.dump(output_dict, outfile) | ||
|
|
||
| @classmethod | ||
| def write_json_from_scenario_log( |
There was a problem hiding this comment.
This seems to be doing the same thing as write_scenario_log_to_json ? And it doesn't make any sense to pass a cls to an instance method. I am not sure if this will work without passing a concrete object to it
There was a problem hiding this comment.
Tested this and it indeed works. I can see it being useful if a user doesn't want to create a LogWriter object just to write the log to disk.
invertedai/logs/common.py
Outdated
There was a problem hiding this comment.
This module is called common but you are importing stuff from one level above. This might easily cause circular imports in the future and break the package level.
Also having docstrings for each method would be very helpful
There was a problem hiding this comment.
What name would you suggest? Perhaps logger.py, logging.py, logs.py, log_utils.py, anything else?
There was a problem hiding this comment.
I can add the docstrings for sure.
There was a problem hiding this comment.
I don't really have much further to add, i will let @rf-ivtdai to take another look
Added tools to be able to conveniently read and write logs in the python SDK.