Change TMS-mode switching to make it less prone to bugs #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by tracker thread left running after destroying wx.App
Switching TMS-mode on/off now always tries to close the project. Previous functionality was buggy.
Canceling TMS-mode change due to unsaved project now works. Removed a line of commented code.
Fix TMS-mode menu item changing even when canceling mode switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, switching TMS-mode used to partially reload the project, causing various issues.
Changed switching TMS-mode to always close the project, prompting the user to save unsaved changes to project if such exist.
Fixes the following mode switching bugs:
Also includes fix for #775