Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #856 #857

Merged
merged 3 commits into from
Oct 6, 2024
Merged

Fix #856 #857

merged 3 commits into from
Oct 6, 2024

Conversation

lukatolo
Copy link

@lukatolo lukatolo commented Oct 4, 2024

Also fix the color of donut during targeting and fix Navigation() references

Also fix the color of donut during targeting and fix Navigation() references
@rmatsuda
Copy link
Collaborator

rmatsuda commented Oct 5, 2024

Hi Luka! Thanks for the PR. Its returning the following error when navigation starts:

File "C:\repository\main-invesalius\invesalius3\invesalius\gui\task_navigator.py", line 1622, in OnStartNavigationButton
Publisher.sendMessage("Start navigation")
File "C:\repository\main-invesalius\invesalius3\invesalius\pubsub\pub.py", line 74, in sendMessage
Publisher.sendMessage(topicName, **msgdata)
File "C:\Users\renan\anaconda3\envs\invesalius-cp311\Lib\site-packages\pubsub\core\publisher.py", line 216, in sendMessage
topicObj.publish(**msgData)
File "C:\Users\renan\anaconda3\envs\invesalius-cp311\Lib\site-packages\pubsub\core\topicobj.py", line 452, in publish
self.__sendMessage(msgData, topicObj, msgDataSubset)
File "C:\Users\renan\anaconda3\envs\invesalius-cp311\Lib\site-packages\pubsub\core\topicobj.py", line 482, in __sendMessage
listener(data, self, allData)
File "C:\Users\renan\anaconda3\envs\invesalius-cp311\Lib\site-packages\pubsub\core\listener.py", line 237, in call
cb(**kwargs)
File "C:\repository\main-invesalius\invesalius3\invesalius\gui\task_navigator.py", line 1609, in OnStartNavigation
self.navigation.StartNavigation(self.tracker, self.icp)
File "C:\repository\main-invesalius\invesalius3\invesalius\navigation\navigation.py", line 685, in StartNavigation
self.pedal_connector.add_callback("navigation", self.PedalStateChanged)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'add_callback'

…Targeting now works with single coil mode by just getting the single coil without ambiguity (multicoil mode will have a different targeting GUI soon)
@lukatolo
Copy link
Author

lukatolo commented Oct 5, 2024

Fixed the careless mistake. It works in single coil mode now.

For targeting with multiple coils, it should work correctly, but the the color of the donut MAY not change correctly to green. This is irrelevant though, since the next PR will change the multicoil target GUI

@rmatsuda
Copy link
Collaborator

rmatsuda commented Oct 5, 2024

Thanks! It's working now. Another thing, the Hide Coil button should also hide the fixed target coil, when target mode is on. So we can see the brain structures behind the target.

@rmatsuda rmatsuda merged commit 1a92b61 into invesalius:master Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants