Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Annotations for tracker.py and iterativeclosestpoint.py #896

Merged
merged 4 commits into from
Feb 23, 2025

Conversation

HossamSaberX
Copy link
Contributor

Type Annotations Added for Navigation Module

Added type annotations to a couple of files from navigation module, addressing issue #497:

  • Enhanced navigation/tracker.py and navigation/iterativeclosestpoint.py with return type annotations
  • Fixed missing method signature type hints
  • Validated with strict mypy flags and ruff checks

To verify the updates, I ran the following mypy command:

mypy invesalius/navigation/tracker.py invesalius/navigation/iterativeclosestpoint.py \
  --follow-imports=skip \
  --disallow-untyped-defs \
  --disallow-any-generics \
  --disallow-incomplete-defs \
  --warn-redundant-casts \
  --warn-unused-ignores \
  --no-implicit-optional \
  --strict-equality \
  --warn-return-any \
  --warn-unused-configs

And the result was:

Success: no issues found in 2 source files

I'm excited about the opportunity to contribute further and bring more improvements as a GSoC 2025 applicant!

@tfmoraes
Copy link
Member

Hi @rmatsuda. Please, check this.

@tfmoraes tfmoraes merged commit e1004e8 into invesalius:master Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants