Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flake #7032

Merged
merged 8 commits into from
Oct 7, 2024
Merged

update flake #7032

merged 8 commits into from
Oct 7, 2024

Conversation

aakropotkin
Copy link
Contributor

Summary

Updates flake.{nix,lock} and makes minor tweaks necessary to build using nix or on a NixOS system.

Related Issues / Discussions

#7011

QA Instructions

Tested locally on a NixOS system.

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added Root python-deps PRs that change python dependencies labels Oct 4, 2024
@aakropotkin aakropotkin mentioned this pull request Oct 7, 2024
1 task
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out!

@psychedelicious
Copy link
Collaborator

There are some minor dependency changes, we'll need do some testing on this after the v5.1.0 release to ensure this doesn't introduce any regressions.

@psychedelicious
Copy link
Collaborator

Did some testing - no issues.

Details

The dep changes are mediapipe, onnx, onnxruntime, which are no longer pinned to specific versions.

First I uninstalled these packages:

...
  Successfully uninstalled mediapipe-0.10.7
...
  Successfully uninstalled onnx-1.15.0
...
  Successfully uninstalled onnxruntime-1.16.3
...

Then I reinstalled my local invokeai, letting pip choose the versions. I got these new packages:

...
Successfully installed InvokeAI-5.1.0 jax-0.4.34 jaxlib-0.4.34 mediapipe-0.10.15 ml-dtypes-0.5.0 onnx-1.17.0 onnxruntime-1.19.2 opt-einsum-3.4.0 protobuf-4.25.5

We use mediapipe for face detection in the mediapipe_face_detection node and the FaceTools nodes. These work fine after the upgrade.

We use onnx and onnxruntime for pose detection in the dw_openpose_detection node. This works fine after the upgrade.

We have the remnants of ONNX SD inference support hanging around in the app, but we don't really support that any more anyways, so no worries there.

I also did a couple normal SDXL generations and they all worked fine.

@psychedelicious psychedelicious merged commit 4770d98 into invoke-ai:main Oct 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-deps PRs that change python dependencies Root
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants