-
Notifications
You must be signed in to change notification settings - Fork 5
Updated packages to latest versions #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Not yet ready for merge. The plugin-base must be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates packages to latest versions across the project, modernizing tooling and dependencies while maintaining compatibility. The changes include upgrading from legacy configuration to modern ESLint/Prettier setups and updating Sentry SDK to v10.
- Upgraded Sentry packages from v7 to latest versions (v7.114.0 for integrations, v10.15.0 for node)
- Modernized tooling configuration by migrating from legacy ESLint/Prettier configs to @ioBroker packages
- Updated TypeScript, Node types, and build tools to current versions
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
package.json | Updated all package versions including Sentry SDK major version upgrade |
src/index.ts | Modernized code with optional chaining, updated export format, and Sentry v10 API changes |
build/index.js | Compiled output reflecting source changes with modern JavaScript features |
eslint.config.mjs | New modern ESLint configuration replacing legacy .eslintrc.json |
prettier.config.mjs | New Prettier configuration replacing legacy config |
README.md | Updated formatting and documentation improvements |
LICENSE | Updated copyright year to 2025 |
.eslintrc.json | Removed legacy ESLint configuration |
prettier.config.js | Removed legacy Prettier configuration |
.npmignore | Removed file (likely replaced by package.json files array) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/index.ts:106
- The change from require() to dynamic import() may cause issues since the imported module structure differs between CommonJS and ES modules. Consider using
await import('@sentry/node')
with proper destructuring or type assertion to ensure API compatibility.
this.Sentry = await import('@sentry/node');
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
"@iobroker/plugin-base": "^2.0.1", | ||
"@sentry/integrations": "^7.55.2", | ||
"@sentry/node": "^7.55.2", | ||
"@iobroker/plugin-base": "^3.0.0 ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a trailing space after the version number that should be removed.
"@iobroker/plugin-base": "^3.0.0 ", | |
"@iobroker/plugin-base": "^3.0.0", |
Copilot uses AI. Check for mistakes.
No description provided.