Fixed show_labels parameter

[jlstevens]

Fixes the show_labels parameter which wasn't doing anything (#10):

I'm not yet sure this is the right fix as I am using an empty string as the label which means the vertical spacing is unchanged. If the labels are truly dropped the widgets should probably be more compressed vertically.

[philippjfr]

I think this is the correct way to disable them, only other thing you could try is setting it to None.

[jlstevens]

I tried dropping the 'title' keyword but I'm not sure this is what we want either:

[jlstevens]

I think this is the correct way to disable them, only other thing you could try is setting it to None.

Right, that is effectively what the second screenshot shows. The sliders compress but there still seems to be a big gap between the text boxes. The values above the sliders have also vanished!

[philippjfr]

That's probably fine tbh, I can only see that option being useful if you've only got one or two parameters.

[jlstevens]

Ok. For reference the diff needed is tiny for the latter (getting rid of it now):

modified   parambokeh/__init__.py
@@ -343,7 +343,7 @@ class Widgets(param.ParameterizedFunction):
         kw = dict(value=value)
 
         if self.p.show_labels is False:
-            kw['title'] = ''
+            kw['title'] = None
         elif self.p.label_formatter is not None:
             kw['title'] = self.p.label_formatter(p_name)
         else:

Though StaticText also needs a tiny edit to avoid showing the repr of None.

Ready to review if you agree the current empty string formatter is the right thing to do.

[jbednar]

This doesn't seem like it's working yet; presumably omitting the values above the sliders should be entirely separate from omitting the labels, and omitting the labels should compress the space in all cases. Doesn't seem ready...