Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@ This project is licensed under the terms of the MIT License. See the [`LICENSE`]

## Project Structure

<!-- doc-gen treeFileExtended -->
<!-- doc-gen treeFileExtended root="(root)" showDescriptions=true -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The generated file tree is incomplete. It's missing dotfiles (e.g., .gitignore, .prettierrc.json) and the .github directory, even though you've provided descriptions for them in markdown-magic.config.js. This can be misleading for readers. The markdown-magic-transform-treefile-extended transform likely has an option to include hidden files and directories. Please enable it to ensure the project structure is fully represented.

```
markdown-magic-transform-acknowledgements/
(root)
├── CHANGELOG.md
├── CONTRIBUTING.md
├── eslint.config.mjs
Expand Down
33 changes: 33 additions & 0 deletions markdown-magic.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,37 @@ module.exports = {
ACKNOWLEDGEMENTS: require('./index.js'),
treeFileExtended: require('markdown-magic-transform-treefile-extended'),
},
transformDefaults: {
treeFileExtended: {
'_file_descriptions.json':
'A file containing descriptions for each file in the project.',
'.gitignore':
'A file that specifies intentionally untracked files that Git should ignore.',
'.prettierrc.json':
'A configuration file for Prettier, a code formatter.',
'CHANGELOG.md':
'A file that contains a curated, chronological list of notable changes for each version of a project.',
'CONTRIBUTING.md':
'A file that provides guidelines for how to contribute to the project.',
'eslint.config.mjs':
'A configuration file for ESLint, a tool for identifying and reporting on patterns found in ECMAScript/JavaScript code.',
'index.js':
'The main entry point of the application, containing the logic for the markdown-magic transform.',
LICENSE:
'A file that contains the license for the project (MIT License).',
'markdown-magic.config.js':
'A configuration file for markdown-magic, a tool for automatically updating markdown files.',
'package-lock.json':
'A file that records the exact version of each installed dependency.',
'package.json':
'A file that contains metadata about the project and its dependencies.',
'README.md': 'A file that provides a high-level overview of the project.',
'RULES_OF_CONDUCT.md':
'A file that outlines the rules of conduct for contributors to the project.',
'.github/workflows/ci.yml':
'A GitHub Actions workflow file for continuous integration.',
'.github/workflows/release-please.yml':
'A GitHub Actions workflow file for automating releases.',
},
},
Comment on lines +8 to +40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding file descriptions is a great improvement for documentation, embedding this large object directly in markdown-magic.config.js makes the configuration file verbose. The presence of a _file_descriptions.json key suggests that markdown-magic-transform-treefile-extended might support loading descriptions from an external JSON file. Consider moving these descriptions to a separate _file_descriptions.json file. This would keep your configuration cleaner and separate configuration from data.

};