fix: upload with params #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
uploadFilewith non-emptyhttpOptions.paramswould result in an error:The cause being
IONFLTRConnectionHelper#setupConnectionwas writing params to the connection'soutputStreamfor PUT and POST requests (which are typically for upload), and later we tried to callconnection.setRequestProperty, but the connection was already ongoing, causing the exception.The fix involved changing how params are passed. For
multipart/form-data, the params are written in the body in that Content-Type's format, as it was already happening withhttpOptions.formData(which may not actually be used atm, but was left for backwards compatibility). For any other kind of request, since the body for upload file will contain binary data, we set the params in the url, like it already happens for download.Type of changes
Tests
Refer to these test apps from OutSystems that add params to downloads and uploads:
Checklist