Skip to content

fix: encode special characters in file path when validating input #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ItsChaceD wants to merge 3 commits into from
Closed

fix: encode special characters in file path when validating input #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c08cafc
fix: encode special characters in file path
ItsChaceD May 21, 2025
1619e04
fix: only encode uri when validating path
ItsChaceD May 21, 2025
395ad71
chore: cleanup whitespace
ItsChaceD May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
<modelVersion>4.0.0</modelVersion>
<groupId>io.ionic.libs</groupId>
<artifactId>ionfiletransfer-android</artifactId>
<version>0.0.1-dev-1</version>
<version>0.0.1-dev-3</version>
</project>
7 changes: 6 additions & 1 deletion src/main/kotlin/io/ionic/libs/ionfiletransferlib/helpers/IONFLTRInputsValidator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import java.util.regex.Pattern
import java.io.File
import java.net.URI
import java.net.URISyntaxException
import java.net.URLEncoder

internal class IONFLTRInputsValidator {

Expand Down Expand Up @@ -36,7 +37,11 @@ internal class IONFLTRInputsValidator {
return try {
val resolvedPath: String
if (path.startsWith("file://")) {
val uri = URI(path)
val encodedPath = URLEncoder.encode(
path.replace("file://", ""),
Charsets.UTF_8.toString()
).replace("+", "%20")
val uri = URI(encodedPath)
if (uri.path == null) {
return false
}
Expand Down