Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vue): refactor vue code snippets to use <script setup> #3120

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

icarusgk
Copy link

This PR aims to replace Vue's code snipets found in the docs that use the setup() function to use the more succint <script setup> syntax as discussed here: #3070 😄

The following components are to be refactored:

  • avatar
  • back-button
  • backdrop
  • badge
  • breadcrumbs
  • button
  • card
  • checkbox
  • chip
  • content
  • datetime
  • fab
  • footer
  • grid
  • header
  • icon
  • img
  • infinite-scroll
  • input
  • item
  • item-divider
  • item-group
  • item-sliding
  • label
  • list
  • list-header
  • loading
  • menu
  • nav (nav-link only, not modal-navigation)
  • note
  • picker
  • popover
  • progress-bar
  • radio
  • range
  • refresher
  • reorder
  • ripple-effect
  • searchbar
  • segment
  • segment-button
  • select
  • skeleton-text
  • spinner
  • split-pane
  • tabs
  • text
  • textarea
  • thumbnail
  • title
  • toast
  • toggle
  • toolbar

Other:

  • animations
  • gestures
  • theming

@vercel
Copy link

vercel bot commented Sep 16, 2023

@icarusgk is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@icarusgk icarusgk changed the title refactor: vue code snippets to use <script setup> docs(vue): refactor vue code snippets to use <script setup> Sep 16, 2023
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 7:42pm

@mapsandapps
Copy link
Contributor

Hi, @icarusgk. Thanks for working on this! You can go ahead and open this PR now for these two components and then create additional PRs to work on migrating the docs for other components as/if you have time. We'd like to go ahead and merge completed ones in small batches like this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants