Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refresher): add ionEnd event #24526

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WhatsThatItsPat
Copy link

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number:
#24524

What is the new behavior?

This adds an ionEnd event as an obverse to the ionStart event.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This PR appears to work for the web, but I'm not sure if more has to be done for the native refreshers. There are a couple of comments that can be cleaned up after clarification on this.

@WhatsThatItsPat WhatsThatItsPat requested a review from a team as a code owner January 6, 2022 20:37
@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Jan 6, 2022
@liamdebeasi liamdebeasi removed the request for review from a team May 22, 2023 15:01
@WhatsThatItsPat WhatsThatItsPat requested a review from a team as a code owner January 24, 2024 17:55
@WhatsThatItsPat WhatsThatItsPat requested review from averyjohnston and removed request for a team January 24, 2024 17:55
@brandyscarney brandyscarney removed the request for review from averyjohnston May 10, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant