Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modalSheet): change gesture to allow draging when content scrolle… #27696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Captainfl4me
Copy link

Change gesture to allow draging when user overscroll

Issue number: #24583


What is the current behavior?

As mentionned in this comment on the issue #24583. Once you can scroll, dragging down on anywhere but the handle when the content is scrolled to the top doesn't do anything, when it should move the modal.

What is the new behavior?

  • When their is a ion-content tag inside a modal and the modal is fully opened (max breakpoint) ion-content is scrollable and scrolling at the top now drag the modal instead of doing nothing.
  • Ion-content only scroll when you drag the content and not the ion-toolbar at the top of the modal

Does this introduce a breaking change?

  • Yes
  • No

Other information

Apart from scrolling and dragging modal everything stay unchanged.

@stackblitz
Copy link

stackblitz bot commented Jun 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jun 24, 2023
@Captainfl4me Captainfl4me requested a review from a team as a code owner January 24, 2024 17:55
@Captainfl4me Captainfl4me requested review from brandyscarney and removed request for a team January 24, 2024 17:55
@brandyscarney brandyscarney removed their request for review February 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant