Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): migrate to new React Output Target with Next.js support #29715

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jul 16, 2024

What is the current behavior?

We have done a lot of work to update the @stencil/react-output-target package to use the Lit wrapper as well as Next.js support. We are at a point where we would like to test the state of the new output target package with ecosystem projects to validate its functionality.

What is the new behavior?

The new output target provides:

  • a bunch of bug fixes due to changes how we wrap Stencil components using the @lit/react wrapper package
  • it exports a runtime now which requires @stencil/react-output-target to be a dependency
  • support for using Ionic within Next.js applications

Does this introduce a breaking change?

  • Yes
  • No

So far I don't see a reason why this could break someones existing code base. That said, more testing is needed to verify this.

Other information

Unfortunately we can't use @stencil/react-output-target yet due to the fact that it requires a more modern moduleResolution like node16 or bundler. The current one (node) is meant to be used for for Node.js versions older than v10, which only support CommonJS require. I've create a separate issue for this.

Update: raised a PR #29717 to enable export maps

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 5:43pm

@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package package: react @ionic/react package labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant