feat(themes): add md theme tokens and update ionic theme to include semantic tokens #30734
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| --ion-font-family: Roboto, "mdTestingFont", sans-serif; | ||
| font-family: Roboto, "mdTestingFont", sans-serif; | ||
| } | ||
|
|
||
| /* TODO(FW-6744): Remove this after adding the ios tokens */ |
There was a problem hiding this comment.
I thought I could remove these but Playwright still needs the iosTestingFont and mdTestingFont.
There was a problem hiding this comment.
It doesn't apply Roboto without the testing font in this file:
--ion-font-family: Roboto, "mdTestingFont", sans-serif;and it doesn't apply the apple font without this either:
--ion-font-family: -apple-system, BlinkMacSystemFont, "iosTestingFont", sans-serif;I thought maybe this code was outdated but it is still needed so I left it. We could look into removing it later.
There was a problem hiding this comment.
That's weird, I wonder why it needs it. Thanks!
core/src/themes/md/dark.tokens.ts
Outdated
| }, | ||
|
|
||
| textColorStep: { | ||
| 50: '#f33f33', |
There was a problem hiding this comment.
So this is weird, but I noticed all of the other colors here seem to be a grey color (#xyxyxy) and this one doesn't follow that pattern, so I looked at it and this one is red. Was that intentional?
Maybe you meant #f3f3f3? That would be grey like the others.
3 participants
Issue number: internal
What is the current behavior?
mdthemeionictheme redefines the base numeric tokensWhat is the new behavior?
configvalues into a separateconfigoption which uses theIonicConfiginterfaceformHighlighttoIonicConfigmdthemeionictheme and adds semantic tokens--ion-font-familyoverrides in favor of the tokensDoes this introduce a breaking change?