fix(modal): allow interaction with parent content through sheet modals in child routes #30839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e aren't allowing clicks through the background
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: core
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
dc6d1ca to
7a814e9
Compare
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
7a814e9 to
f776b49
Compare
2 tasks
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
f776b49 to
34d3993
Compare
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
34d3993 to
3050ddf
Compare
…s showBackdrop=false in child routes
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
3050ddf to
cc6727a
Compare
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
a723344 to
ef60cf1
Compare
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
b662863 to
4454872
Compare
ShaneK
force-pushed
the
fix/sheet-modals
branch
from
63d3985 to
38743ff
Compare
ShaneK
changed the title
thetaPC
requested changes
Dec 8, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
The main thing is that I couldn't get the Angular page to interact for me. Please let me know if I just missed something.
| * passthrough on child route page wrappers and nested router outlets. | ||
| */ | ||
| private setupChildRoutePassthrough() { | ||
| const pageParent = this.getOriginalPageParent(); |
Contributor
There was a problem hiding this comment.
I noticed that getOriginalPageParent() gets called twice, here and cleanupChildRoutePassthrough(). Is it possible to save the pageParent as a private variable instead? So we don't have to run the while loop more than once?
Comment on lines
+5
to
+8
| /** | ||
| * Child route component containing only the sheet modal with showBackdrop=false. | ||
| * Verifies issue https://github.com/ionic-team/ionic-framework/issues/30700 | ||
| */ |
Contributor
There was a problem hiding this comment.
Good call on having this comment! I don't we're in the habit of doing like this when it comes to Angular, React, or Vue.
Comment on lines
+21
to
+26
| test('should allow interacting with parent content while modal is open in child route', async ({ page }) => { | ||
| await expect(page.locator('ion-modal.show-modal')).toBeVisible(); | ||
|
|
||
| await page.locator('#increment-btn').click(); | ||
| await expect(page.locator('#background-action-count')).toHaveText('1'); | ||
| }); |
Contributor
There was a problem hiding this comment.
I was testing this scenario manually and I'm not able to interact with the background. This is happening on Firefox, Chrome, and Safari.
Screen.Recording.2025-12-08.at.11.49.19.AM.mov
| { path: 'modal', loadComponent: () => import('../modal/modal.component').then(c => c.ModalComponent) }, | ||
| { path: 'modal-sheet-inline', loadComponent: () => import('../modal-sheet-inline/modal-sheet-inline.component').then(c => c.ModalSheetInlineComponent) }, | ||
| { path: 'modal-dynamic-wrapper', loadComponent: () => import('../modal-dynamic-wrapper/modal-dynamic-wrapper.component').then(c => c.ModalDynamicWrapperComponent) }, | ||
| { path: 'modal-child-route', redirectTo: '/standalone/modal-child-route/child', pathMatch: 'full' }, |
Contributor
There was a problem hiding this comment.
Unless I didn't see it, it would be great to add a link on the Standalone page.
| */ | ||
| describe('IonModal: Sheet in Child Route with Nested Routing', () => { | ||
| beforeEach(() => { | ||
| cy.visit('/overlay-components/modal-sheet-child-route/child'); |
Contributor
There was a problem hiding this comment.
Can we add this link to the main page? It would make it easier to navigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30700
What is the current behavior?
When a sheet modal with showBackdrop=false is rendered in a child route (nested ion-router-outlet), the parent content becomes non-interactive. Clicks on buttons or other interactive elements in the parent component are blocked, even though showBackdrop=false should allow background interaction.
Two separate issues contributed to this bug:
backdropBreakpoint: TheshouldLockRootlogic inoverlays.tsdidn't account forbackdropBreakpoint. Modals withbackdropBreakpoint > 0were still locking the root witharia-hidden, even though developers expect background interaction when the modal is below the backdrop breakpoint.ion-page) and its parention-router-outletremain in the DOM withposition: absolutecovering the viewport. Even after the modal is moved toion-appand haspointer-events: none, these wrapper elements block clicks to the parent page's content.This issue stems from #30563, which added root-locking behavior that didn't account for modals that allow background interaction. A partial fix in #30689 partially addressed
showBackdrop=falseandfocusTrap=false, but missedbackdropBreakpoint.What is the new behavior?
Sheet modals with showBackdrop=false or focusTrap=false now correctly allow interaction with parent content when the modal is in a child route.
Improvements:
Does this introduce a breaking change?
Other information
Dev build: