Support remapping all severity levels #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- print messages when using FSC args, too - support remapping of all severity levels
baronfel
reviewed
Oct 30, 2023
src/FSharp.Analyzers.Cli/Program.fs
Outdated
| | Report of string | ||
| | FSC_Args of string | ||
| | Verbose | ||
| | [<Unique>] Project of string list |
There was a problem hiding this comment.
does Unique require only a single instance of each of these flags? It's often nicer/easier for users (especially automated scripts!) to specify the same flag multiple times, aggregating all of the values of each time the flag is provided.
> app --project myproject.fsproj --project anotherproject.fsprojis the same as
> app --project myproject.fsproj,anotherproject.fsproj
There was a problem hiding this comment.
Okay, that's supported now. I did the same for --analyzers-path as it felt somewhat related to proj paths.
I'm not sure about the other ones.
nojaf
reviewed
Oct 31, 2023
src/FSharp.Analyzers.Cli/Program.fs
Outdated
|
|
||
| if not (severityMapping.IsValid()) then | ||
| printError | ||
| "An analyzer code may only be listed once in the <fail-on-warnings> and <treat-as-severity> arguments." |
There was a problem hiding this comment.
I think this is a bit questionable.
Fail On Warnings feels like the ugly duck. Is this not, in concept, replaced by TreatAsError?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.