Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning if the path it's trying to load analyzers from doesn't … #189

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Dec 31, 2023

…exist

Just a thought in case anyone else thinks it's helpful -

If you run the cli tool and specify a project that doesn't exist then you get a warning logged, but if the analyzers-path doesn't exist then you get no output with default logging, and in detailed mode get a note about trying to load analyzers followed by Registered 0 analyzers from 0 dlls but no actual error or anything - so, I just thought it might be useful if there was an actual warning in that case.

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dawedawe dawedawe merged commit 727a9c1 into ionide:main Jan 2, 2024
2 checks passed
@Numpsy Numpsy deleted the rw/analyser_path_warn branch January 2, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants