Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the console foreground colour with control codes #216

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Jul 27, 2024

refs #215

Printing the 0m control code looks like how Fargo resets the colour, and that seems to work for me here on Windows (cmd.exe and windows terminal).
I haven't tested it on any other OS yet, and not sure if there is a need to reset Console.ForegroundColor as well as printing the codes.

Copy link
Contributor

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens on Linux, too. I wonder if this is a regression from us or from something else as it's pretty obvious 🤷
Anyway, thanks a lot for the fix.

@dawedawe
Copy link
Contributor

@Numpsy Could you add a changelog entry, please? Then it's good to merge.

@Numpsy
Copy link
Contributor Author

Numpsy commented Jul 30, 2024

added

@dawedawe dawedawe merged commit 6dd3cd1 into ionide:main Jul 30, 2024
2 checks passed
@dawedawe
Copy link
Contributor

Thanks!

@dawedawe dawedawe linked an issue Jul 30, 2024 that may be closed by this pull request
@Numpsy Numpsy deleted the console_colours branch July 31, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console colour not being reset before fsharp-analyzers cli tool exits?
2 participants