Prevent File Locking Issue

[1eyewonder]

Problem

In VSCode I currently have the following settings to enable analyzers in the IDE.

{
    "FSharp.enableAnalyzers": true,
    "FSharp.analyzersPath": [
        "packages/Analyzers"
    ],
}

When switching between branches of my codebase, if there are different versions of my analyzers, I will get an error during the paket restore step due to the files being used. My current workaround is to manually delete the folder listed above and then restore my solution.

Proposed Solution

In order to circumvent this, there appears to be a setting in the package we are consuming to allow loading the assemblies into memory. Looking through the code, it does not appear we are using this setting nor is it overriding any hot reload functionality.

CreateFromAssemblyFile

PluginConfig constructor

[1eyewonder]

Here is some additional context natemcmaster/DotNetCorePlugins#87

[TheAngryByrd]

Looks good but I think we wanna test in FSAC to make sure this works as expected.

[1eyewonder]

Local FSAC

• Pointed towards local FSharp.Analyzers.SDK with the proposed changes
  • 
• Removed references to nuget package
  • 

Delete Script

The below script is what I use to test if a file is locked by Windows

open System.IO

let path = @"packages/analyzers"
Directory.Delete(path, true)

Opening Using Local Repo as Is

• Analyzers exist upon opening
  • 
• Analyzers functional
  • 
• Run the above script
  • 

Opening Using Local Repo & Local FSAC

• Set local fsac dll path
  • 
• Analyzers exist upon opening
  • 
• Analyzers functional
  • 
• Running the script successfully deletes the packages and does not throw an error
  •