Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSAC Not exiting on macos/linux #1141

Merged

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Jul 12, 2023

WHAT

🤖 Generated by Copilot at aefe387

Fixed a macOS bug that caused FsAutoComplete to hang by calling exit explicitly in Program.fs. The bug was related to the argument parser.

🤖 Generated by Copilot at aefe387

entry function
calls exit to avoid stall
autumn bug is fixed

🐛🍎🚪

WHY

Fixes #1117

Why do we need to do this specifically for macos? I have no idea.

HOW

🤖 Generated by Copilot at aefe387

  • Fix bug where program stalls on macOS by explicitly calling exit with argument parser results (link)

@TheAngryByrd TheAngryByrd merged commit 24b547d into ionide:main Jul 14, 2023
9 of 10 checks passed
@TheAngryByrd TheAngryByrd changed the title Force process exit in main FSAC Not exiting on macos/linux Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FsAutoComplete process doesn't exit correctly when AdaptiveFSharpLspServer is used
1 participant