Declarations only required ParseResults #1150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 09c7a10
Improve document and workspace symbol features by using parsed results of open files. Rename and update some fields and functions in
AdaptiveFSharpLspServer.fs
to reflect this change.🤖 Generated by Copilot at 09c7a10
📄🗂️🐛
WHY
Discussed in #1149 (comment)
HOW
🤖 Generated by Copilot at 09c7a10
openFilesToCheckedDeclarations
andgetAllDeclarations
toopenFilesToDeclarations
andgetAllOpenDeclarations
respectively, to reflect that they are based on parsed results of open files, not checked results (link)getDeclarations
andworkspaceSymbol
functions to use the renamed values and avoid using potentially outdated or missing values (link, link)