Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ATN GTS metrics #105

Merged
merged 3 commits into from
Jan 29, 2025
Merged

refactor ATN GTS metrics #105

merged 3 commits into from
Jan 29, 2025

Conversation

MathewBiddle
Copy link
Contributor

addresses #35

@MathewBiddle MathewBiddle requested a review from ocefpaf January 28, 2025 19:34
@MathewBiddle
Copy link
Contributor Author

This is probably going to have conflicts once #102 is merged as I had to update the github action.

@MathewBiddle
Copy link
Contributor Author

xref:

MathewBiddle
MathewBiddle commented Jan 29, 2025
View reviewed changes
website/create_gts_atn_landing_page.py

fig = plotly.io.to_html(fig, full_html=False)

return fig


def main(org_config):
configs = dict()
def get_atn_gts_metrics():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After we merge this, let's consider if this function should be moved to ioos_metrics proper.

@MathewBiddle
Copy link
Contributor Author

Yay! All checks pass and merge conflicts are resolved!!

@MathewBiddle MathewBiddle merged commit 716f336 into ioos:main Jan 29, 2025
4 checks passed
@MathewBiddle MathewBiddle deleted the refactor_atn branch January 29, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MathewBiddle