Skip to content

Conversation

@iosefa
Copy link
Owner

@iosefa iosefa commented Mar 23, 2025

Visualization:

  • Added an optional fig_title parameter to plot_2d for custom plot titles.
  • Refactored plotting functions (including plot_pad) for easier slicing and customization.

Calculations:

  • Updated calculate_pad and calculate_pai so columns with zero returns become NaN, avoiding misleading zero values.

Outlier Removal:

  • Extended remove_outliers_and_clean with a new remove parameter to optionally discard outliers entirely.

iosefa added 3 commits March 16, 2025 20:08
This update introduces the `fig_title` parameter to the `plot_2d` function, allowing custom titles for visualizations. If not provided, a default title based on x and y dimensions is generated. This enhances flexibility and improves customization in plots.
Improved `plot_2d` to support slicing and customizable colorbars, while enhancing `plot_pad` with collapsing and dynamic titles. Added parameter validation and detailed documentation for better usability and clarity.
Updated PAD calculation to set columns with zero returns to NaN and adjusted PAI to handle NaN values properly. Modified tests to reflect these changes and ensure consistency. Removed redundant content from the example notebook for clarity and brevity.
@iosefa iosefa self-assigned this Mar 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyforestscan/filters.py 11.11% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
pyforestscan/calculate.py 100.00% <100.00%> (ø)
tests/test_calculate.py 100.00% <100.00%> (ø)
pyforestscan/filters.py 34.14% <11.11%> (-7.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iosefa iosefa merged commit ebb8c85 into main Mar 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants