Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support macOS >= 10.15 #7332

Merged
merged 11 commits into from
Aug 21, 2023
Merged

fix: support macOS >= 10.15 #7332

merged 11 commits into from
Aug 21, 2023

Conversation

marc2332
Copy link
Collaborator

Closes #7326

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd changed the title fix: Fix support macOS >= 10.13 fix: support macOS >= 10.13 Aug 19, 2023
@begonaalvarezd begonaalvarezd changed the title fix: support macOS >= 10.13 fix: support macOS >= 10.15 Aug 20, 2023
@begonaalvarezd begonaalvarezd linked an issue Aug 20, 2023 that may be closed by this pull request
[Task]: fix support macOS >= 10.15 #7326
Closed
@begonaalvarezd begonaalvarezd marked this pull request as ready for review August 20, 2023 18:27
begonaalvarezd
begonaalvarezd approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd merged commit 5b1c6d5 into release/desktop-1.7.4 Aug 21, 2023
10 of 11 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/patch-mac-os-rocksdb branch August 21, 2023 13:57
This was referenced Aug 21, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@rajivshah3 rajivshah3 Awaiting requested review from rajivshah3

Assignees

@marc2332 marc2332

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: fix support macOS >= 10.15
2 participants
@marc2332 @begonaalvarezd