chore: Update to @electron/notarize for new notarytool #7678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am already upgrading @electron/notarize in #7675 |
marc2332
force-pushed
the
chore/update-electron
branch
2 times, most recently
from
c1b7510
to
632ee34
Compare
rajivshah3
force-pushed
the
chore/update-notarize
branch
from
6e0c495
to
45ab111
Compare
16 tasks
rajivshah3
added
os:mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses latest version of
@electron/notarize(new version ofelectron-notarize) to notarize macOS apps. This is necessary because Apple will be ending support foraltooltomorrow and will requirenotarytoolin the future (https://developer.apple.com/documentation/technotes/tn3147-migrating-to-the-latest-notarization-tool). I didn't realize they made this change until a week ago 😅Changelog
N/A
Testing
Workflow runs successfully, resulting app launches successfully
Platforms
Instructions
App launches, with the OS displaying something along the lines of "Apple has checked this application for malicious software and none was found" (I don't remember the exact text)
Checklist