feat!: add TransactionData enum, rename Transaction to TransactionDataV1 #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
changed the title
Thoralf-M
force-pushed
the
feat/TransactionData
branch
2 times, most recently
from
8aa486b to
6faf35b
Compare
Thoralf-M
force-pushed
the
feat/TransactionData
branch
4 times, most recently
from
455a8fe to
1ebf584
Compare
Thoralf-M
force-pushed
the
feat/TransactionData
branch
from
1ebf584 to
5588389
Compare
Alex6323
reviewed
Oct 7, 2025
Alex6323
reviewed
Oct 7, 2025
Alex6323
reviewed
Oct 7, 2025
Alex6323
approved these changes
Oct 7, 2025
| } | ||
|
|
||
| txnBytes, err := txn.BcsSerialize() | ||
| txnBytes, err := txn.AsV1().BcsSerialize() |
There was a problem hiding this comment.
Do we not want an impl on the enum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14