Skip to content

Conversation

@Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Nov 4, 2025

Added missing types/fields that are defined in the graphql schema but were missing in the query types. Only the validator fields I left commented out as these would make the query too big and make it fail: Query error: [Query payload is too large. The maximum allowed is 5000 bytes]
Also changed the iota_total_supply type to work, as the number it holds is larger than i32::MAX and decoding failed without this change

@Thoralf-M Thoralf-M marked this pull request as ready for review November 4, 2025 12:39
@Thoralf-M Thoralf-M requested a review from a team as a code owner November 4, 2025 12:39
@DaughterOfMars
Copy link
Contributor

Considering that users can create their own queries and call run_query or run_query_from_json, do we really want to do this? Especially considering that queries can reach a byte limit, I feel that this is unnecessary.

@Thoralf-M
Copy link
Member Author

Considering that users can create their own queries and call run_query or run_query_from_json, do we really want to do this? Especially considering that queries can reach a byte limit, I feel that this is unnecessary.

TBH I'm also not sure about it, but the query now still has the size that is fine and this way more data is available to the users (also the structs in the crate are a good example one can copy paste and modify). Building custom queries makes sense to make the queries more efficient, but is also a bit harder/more annoying to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants