Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: improve wallet creation #2183

Merged
merged 18 commits into from
Mar 21, 2024

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Mar 15, 2024

Description of change

This PR suggests the changes:

  • allow to specify alias in the InitParameters, because that just seems right to allow that;
  • removes the default bip path in InitParameters, because defaulting to a certain network could be confusing for some users;
  • after the wallet has been successfully created, more information is printed and logged as a summary, because that not only helps us debugging from user provided log files, but also tells the user whether the wallet is how s/he wanted it to be created.

Links to any relevant issues

Fixes #2052

@Alex6323 Alex6323 linked an issue Mar 15, 2024 that may be closed by this pull request
4 tasks
@Alex6323 Alex6323 marked this pull request as ready for review March 15, 2024 11:41
@Alex6323 Alex6323 marked this pull request as draft March 15, 2024 11:43
@Alex6323 Alex6323 marked this pull request as ready for review March 18, 2024 15:00
cli/src/cli.rs Outdated Show resolved Hide resolved
cli/src/cli.rs Outdated Show resolved Hide resolved
Alex6323 and others added 2 commits March 19, 2024 09:59
Co-authored-by: DaughterOfMars <alexandcoats@gmail.com>
cli/src/cli.rs Outdated Show resolved Hide resolved
cli/src/cli.rs Outdated Show resolved Hide resolved
cli/src/helper.rs Outdated Show resolved Hide resolved
cli/src/helper.rs Outdated Show resolved Hide resolved
@Alex6323 Alex6323 force-pushed the cli/improve-init-parameters branch from a9f2176 to 860d3ed Compare March 19, 2024 11:57
cli/src/helper.rs Outdated Show resolved Hide resolved
cli/src/cli.rs Outdated Show resolved Hide resolved
cli/src/helper.rs Outdated Show resolved Hide resolved
Alex6323 and others added 2 commits March 19, 2024 15:39
Co-authored-by: DaughterOfMars <alexandcoats@gmail.com>
DaughterOfMars
DaughterOfMars previously approved these changes Mar 19, 2024
cli/src/cli.rs Outdated Show resolved Hide resolved
cli/src/helper.rs Outdated Show resolved Hide resolved
cli/src/helper.rs Outdated Show resolved Hide resolved
cli/src/helper.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars previously approved these changes Mar 20, 2024
cli/src/cli.rs Outdated Show resolved Hide resolved
@Alex6323 Alex6323 merged commit fe407ff into iotaledger:2.0 Mar 21, 2024
20 checks passed
@Alex6323 Alex6323 deleted the cli/improve-init-parameters branch March 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Refactor InitParameters?
4 participants