Fix restore_from_stronghold_snapshot() with same source and target path #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arget path are the same
Thoralf-M
changed the title
Thoralf-M
force-pushed
the
fix/stronghold-restore-with-same-path
branch
from
842e583
to
1fd27b6
Compare
thibault-martinez
approved these changes
Apr 22, 2024
DaughterOfMars
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fix restore_from_stronghold_snapshot() for the case when source and target path are the same. Without this change std::fs::copy() truncates the backup file, resulting in
Error: Stronghold(Client(ClientDataNotPresent))Port 8084 seems to be used by Mono actions/runner-images#2820, so replaced this port for the dashboard
Type of change
How the change has been tested
Added test