This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
Minor formatting cleanup, base class implementation, some minor refactoring and upgrade to .NET 4.62. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, renamed base classes and implemented consistently, minor refactorings. Updated to .NET 4.7.
|
Some unit tests are failing but the failures are unrelated to these changes. The unit tests were already failing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set has the following:
Fixed some files that did not have Windows line terminations (consistently).
Minor formatting changes: added or removed lines to make the code readability consistent.
Made IotaRequest and IotaResponse classes abstract and renamed them to IotaRequestBase and IotaResponseBase. Implemented them on their corresponding classes consistently.
Upgraded to .NET 4.62 and updated NuGet packages.
Minor refactoring
-- Made some for loops foreach loops
-- Used some null coalescing to simplify code.
-- Added some XML comments where missing.
-- Other minor refactoring.