feat(iota-indexer, iota-json-rpc-types, ts-sdk, explorer): Support TransactionKind filters
#5801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
iota-ci
added
infrastructure
github-actions
bot
added
ts-sdk
samuel-rufi
force-pushed
the
feat/rpc-transaction-kind-filter
branch
from
db6ad7e to
4eb77bf
Compare
iota-ci
added
infrastructure
kodemartin
approved these changes
Mar 6, 2025
samuel-rufi
force-pushed
the
feat/rpc-transaction-kind-filter
branch
from
4eb77bf to
d2aed4c
Compare
begonaalvarezd
approved these changes
Mar 6, 2025
samuel-rufi
requested review from
msarcev,
alexsporn,
thibault-martinez,
DaughterOfMars and
Dr-Electron
as code owners
samuel-rufi
force-pushed
the
feat/rpc-transaction-kind-filter
branch
from
a6c7f7c to
d2aed4c
Compare
…ters in `query_transaction_blocks_impl` (#5434) * feat: implement TransactionFilter::TransactionKind{In} * refactor: Update openrpc.json * refactor: Format * refactor: Clippy * refactor: Remove TransactionFilter::TransactionKindIn filter * Simplify format! Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> * Revert "refactor: Remove TransactionFilter::TransactionKindIn filter" This reverts commit d993a49. * types: Differ between SystemTransactions * types: Simplify format! * types: impl From<&TransactionKind> * types: Change to human readable params * types: Rename constant * types: Use strum * types: Update openrpc spec * types: Improve error message * Refactor: Maintain backward compatibility with former iota_indexer::types::TransactionKind enum Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org> * refactor: Use IotaTransactionKind directly in the filter * refactor: Rename var * refactor: Generate Spec * test(iota-indexer): add test for TransactionKind(In) filter * refactor: Document `SystemTransaction` and impl `is_system_transaction` to better align `IotaTransactionKind` with the `TransactionKind` type * refactor: Regenerate openrpc spec --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org> Co-authored-by: Roman Overko <roman.overko@iota.org>
…ctionKind` and `TransactionKindIn` (#5469) * feat: implement TransactionFilter::TransactionKind{In} * refactor: Update openrpc.json * refactor: Format * refactor: Clippy * chore: re-generate ts sdk files after openrpc schema update * feat(ts-sdk): add TransactionKind public enum * refactor(explorer): update transactionKind type * refactor(ts-sdk): Update graphql codegen * feat(iota-indexer, iota-json-rpc-types): Support transaction kind filters in `query_transaction_blocks_impl` (#5434) * feat: implement TransactionFilter::TransactionKind{In} * refactor: Update openrpc.json * refactor: Format * refactor: Clippy * refactor: Remove TransactionFilter::TransactionKindIn filter * Simplify format! Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> * Revert "refactor: Remove TransactionFilter::TransactionKindIn filter" This reverts commit d993a49. * types: Differ between SystemTransactions * types: Simplify format! * types: impl From<&TransactionKind> * types: Change to human readable params * types: Rename constant * types: Use strum * types: Update openrpc spec * types: Improve error message * Refactor: Maintain backward compatibility with former iota_indexer::types::TransactionKind enum Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org> * refactor: Use IotaTransactionKind directly in the filter * refactor: Rename var * refactor: Generate Spec * test(iota-indexer): add test for TransactionKind(In) filter * refactor: Document `SystemTransaction` and impl `is_system_transaction` to better align `IotaTransactionKind` with the `TransactionKind` type * refactor: Regenerate openrpc spec --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org> Co-authored-by: Roman Overko <roman.overko@iota.org> * feat(ts-sdk): update TransactionKind enum and introduce IotaTransactionKind type * fix(ts-sdk): enable balance change display in payIota function options * refactor(explorer, ts-sdk): update transaction kind type to IotaTransactionKind * chore: add changeset --------- Co-authored-by: samuel_rufi <samuel.rufinatscha@iota.org> Co-authored-by: marc2332 <mespinsanz@gmail.com> Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org> Co-authored-by: Roman Overko <roman.overko@iota.org> Co-authored-by: Panteleymonchuk <panteleymonchuk@gmail.com>
samuel-rufi
force-pushed
the
feat/rpc-transaction-kind-filter
branch
from
71959a4 to
2717145
Compare
muXxer
requested changes
Mar 11, 2025
sergiupopescu199
approved these changes
Mar 12, 2025
6 tasks
piotrm50
approved these changes
Mar 17, 2025
…s not present; avoid duplicate values in `IN(..)` filter; improve comments
lucas-tortora
approved these changes
Mar 17, 2025
muXxer
approved these changes
Mar 17, 2025
…tion for the "all" case
samuel-rufi
force-pushed
the
feat/rpc-transaction-kind-filter
branch
from
69cfbcf to
5a34c90
Compare
* chore(ts-sdk): regenerate graphql after infra changes * chore(ts-sdk): upgrade graphql transport after re-generated codebase * feat(graphql-transport): Fix mapping of transaction kind filter * feat(graphql-transport): Revert compatibility test change * feat(graphql-transport): typo * feat(graphql-transport): Improve typing --------- Co-authored-by: Mario Sarcevic <mario.sarcevic@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds support for the
TransactionKindandTransactionKindInfilters.Relevant PRs
#5434
#5469
Type of change