Skip to content

chore(protocol-research): ChangeEpoch validity checks #9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyberphysic4l wants to merge 1 commit into
base: protocol-research/feat/score-integration
Choose a base branch
from
+16 −19
Open

chore(protocol-research): ChangeEpoch validity checks #9515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions crates/iota-types/src/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,12 +620,11 @@ impl EndOfEpochTransactionKind {
"selecting committee only among validators supporting the protocol version not supported".to_string(),
));
}
// This has to be uncommented before merging to develop
// if config.score_based_rewards() {
// return Err(UserInputError::Unsupported(
// "score based rewards enabled and
// required".to_string(), ));
// }
if config.score_based_rewards() {
return Err(UserInputError::Unsupported(
"score based rewards should not be enabled".to_string(),
));
}
}
Self::ChangeEpochV2(_) => {
if !config.protocol_defined_base_fee() {
Expand All @@ -638,12 +637,11 @@ impl EndOfEpochTransactionKind {
"selecting committee only among validators supporting the protocol version not supported".to_string(),
));
}
// This has to be uncommented before merging to develop
// if config.score_based_rewards() {
// return Err(UserInputError::Unsupported(
// "score based rewards enabled and
// required".to_string(), ));
// }
if config.score_based_rewards() {
return Err(UserInputError::Unsupported(
"score based rewards should not be enabled".to_string(),
));
}
}
Self::ChangeEpochV3(_) => {
if !config.protocol_defined_base_fee() {
Expand All @@ -656,12 +654,11 @@ impl EndOfEpochTransactionKind {
"selecting committee only among validators supporting the protocol version required".to_string(),
));
}
// This has to be uncommented before merging to develop
// if config.score_based_rewards() {
// return Err(UserInputError::Unsupported(
// "score based rewards enabled and
// required".to_string(), ));
// }
if config.score_based_rewards() {
return Err(UserInputError::Unsupported(
"score based rewards should not be enabled".to_string(),
));
}
}
Self::ChangeEpochV4(_) => {
if !config.protocol_defined_base_fee() {
Expand All @@ -676,7 +673,7 @@ impl EndOfEpochTransactionKind {
}
if !config.score_based_rewards() {
return Err(UserInputError::Unsupported(
"score based rewards not enabled".to_string(),
"score based rewards should be enabled".to_string(),
));
}
}
Expand Down
Loading