Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues reported by SonarCloud (11) #490

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix issues reported by SonarCloud (11) #490

merged 3 commits into from
Sep 26, 2023

Conversation

Danielius1922
Copy link
Member

No description provided.

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (18e2589), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/bugfix/sc-fixes-11 branch 5 times, most recently from 1b8a938 to bfe15f5 Compare July 25, 2023 09:54
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/sc-fixes-11 branch 4 times, most recently from 275bfeb to 4bbfc13 Compare August 13, 2023 10:23
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/sc-fixes-11 branch 4 times, most recently from 8b46be8 to e54e2c6 Compare August 25, 2023 21:18
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/sc-fixes-11 branch 4 times, most recently from c483f5b to 74fe139 Compare September 7, 2023 08:12
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

5.4% 5.4% Coverage
1.8% 1.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Sep 26, 2023
@Danielius1922 Danielius1922 marked this pull request as ready for review September 26, 2023 22:51
@Danielius1922 Danielius1922 merged commit e5899d1 into master Sep 26, 2023
119 of 121 checks passed
@Danielius1922 Danielius1922 deleted the adam/bugfix/sc-fixes-11 branch September 26, 2023 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
OCF Conformance Testing OCF Conformance Testing required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Danielius1922