Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to stratum-deps v1.3.4 #723

Merged
merged 4 commits into from
Jan 1, 2025
Merged

Update to stratum-deps v1.3.4 #723

merged 4 commits into from
Jan 1, 2025

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Jan 1, 2025

  • Modify StratumDependencies.cmake to import re2 package.

  • Link with re2::re2 instead of gRPC::re2.

  • Update stratum submodule to use re2::re2 instead of gRPC::re2.

Note

Merge ipdk-io/stratum-dev#322 and update stratum submodule reference before merging this PR.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>
Signed-off-by: Derek Foster <justffoulkes@gmail.com>
Signed-off-by: Derek Foster <justffoulkes@gmail.com>
@ffoulkes ffoulkes changed the title Modify to use discrete re2 package Update to stratum-deps v1.3.4 Jan 1, 2025
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Derek Foster <justffoulkes@gmail.com>
@ffoulkes ffoulkes merged commit 1eafa1e into main Jan 1, 2025
9 checks passed
@ffoulkes ffoulkes deleted the re2-fix branch January 1, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants