Fix bug found by WriteIndirectMeterEntryTest test case #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The WriteIndirectMeterEntryTest test case failed because WriteMeterEntry() was calling FindResourceTypeByID() with the meter ID returned by GetTdiRtId(), which is not defined in P4Info. Changed it to look up meter_entry.meter_id() instead. Also renamed the variable to which the value returned by GetTdiRtId() is assigned, from meter_id to meter_rt_id, in hopes of reducing confusion in the future. Signed-off-by: Derek Foster <derek.foster@intel.com>
Signed-off-by: Derek Foster <derek.foster@intel.com>
- Created a separate GitHub issues for each of the failing test cases, so they can be tracked individually. Updated the comments in tdi_table_manager_test_case.cc to refer to the correct issue. Signed-off-by: Derek Foster <derek.foster@intel.com>
ffoulkes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WriteIndirectMeterEntryTesttest case failed becauseWriteMeterEntry()was callingFindResourceTypeByID()with the ID returned byGetTdiRtId(), not a P4 resource ID. Changed it to look upmeter_entry.meter_id()instead.Also renamed the variable to which the value returned by
GetTdiRtId()is assigned, frommeter_idtometer_rt_id, in hopes of reducing confusion in the future.Reenabled the test case.
See issue #306 for a description of the problem.