Tweak category buttons #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use proper button rather than custom class. * Remove redundant 'view all' button and text. * Reduce icon size, improve render quality. Rationale: move weight from headers to content.
Rationale: a 'show more' button (with 3 dots) is a common pattern and matches user expectation. In addition, particularly for documents, the click to expand is less disruptive for users.
|
I like it but i think it should only be visible on the All types page, right? No need to display it anymore after you click on it. N.b. Just quickly checked on my phone, will look better later. |
femans
reviewed
Oct 27, 2022
femans
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read full commit messages for background/rationale.
Closes #266.
Would be great if we could throw this live before the camp. ^^