Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use self-hosted runner for faster main build #948

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 8, 2023

The goal is to make it faster, this PR aims to test if using self-hosted runner speeds up release build.

If it is ok, we can decide to set CI_BUILD_RUNS_ON on this repo instead.

cc @galargh for sanity check + if we need to safelist this repo somewhere for this to work (i tried to set CI_BUILD_RUNS_ON but https://github.com/ipfs/distributions/actions/runs/5799417224/job/15719370344 was stuck waiting for free runner and i cancelled it).

@lidel lidel requested a review from galargh August 8, 2023 16:41
@galargh
Copy link
Contributor

galargh commented Aug 8, 2023

cc @galargh for sanity check + if we need to safelist this repo somewhere for this to work (i tried to set CI_BUILD_RUNS_ON but https://github.com/ipfs/distributions/actions/runs/5799417224/job/15719370344 was stuck waiting for free runner and i cancelled it).

Yes, we do! I'll do that first thing tomorrow morning.

@lidel lidel force-pushed the feat/ci-build-on-self-hosted-runner branch from b6368b2 to b13ca95 Compare August 8, 2023 16:53
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@galargh
Copy link
Contributor

galargh commented Aug 11, 2023

We have access to self-hosted runners here now 🥳 but we do need to make some adjustments before we update the CI_BUILD_RUNS_ON var. E.g. https://github.com/ipfs/distributions/actions/runs/5836552866/job/15830374575 - we'll need to update the ipfs setup action so that it works on self-hosted. I'll get back to it next week.

Edit: I fixed the setup ipfs action. We'll see how far it takes us.

Edit2: Looks like we're getting stuck at/after comparing versions with /ipfs/QmQAqFeyrqvLR1m8TWugeQojhzTKp1ASxTicM3sPru1ULF/kubo/versions

@lidel lidel force-pushed the feat/ci-build-on-self-hosted-runner branch from 56e7934 to 3f9e4c9 Compare September 20, 2023 13:13
@lidel lidel temporarily deployed to Deploy September 20, 2023 13:24 — with GitHub Actions Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

@lidel lidel marked this pull request as ready for review September 20, 2023 13:36
@lidel lidel marked this pull request as draft September 20, 2023 13:37
@lidel
Copy link
Member Author

lidel commented Sep 20, 2023

@galargh rebased, is the issue gone?

@galargh
Copy link
Contributor

galargh commented Sep 20, 2023

Seems so, I think we're good to go 😁 I'll take the vars in a sec.

@galargh galargh marked this pull request as ready for review September 20, 2023 15:40
Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set CI_BUILD_RUNS_ON var to ["self-hosted", "linux", "x64", "2xlarge"] again.

After we merge it, that var will also affect the persist job.

Edit I set the variable.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@galargh galargh temporarily deployed to Deploy September 20, 2023 15:48 — with GitHub Actions Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

@galargh galargh temporarily deployed to Deploy September 20, 2023 15:56 — with GitHub Actions Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

@galargh galargh merged commit c012a48 into master Sep 20, 2023
5 checks passed
@galargh galargh deleted the feat/ci-build-on-self-hosted-runner branch September 20, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants