-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): use self-hosted runner for faster main build #948
Conversation
Yes, we do! I'll do that first thing tomorrow morning. |
b6368b2
to
b13ca95
Compare
We have access to self-hosted runners here now 🥳 but we do need to make some adjustments before we update the Edit: I fixed the setup ipfs action. We'll see how far it takes us. Edit2: Looks like we're getting stuck at/after |
56e7934
to
3f9e4c9
Compare
This change produced no new differences in built artifacts. |
@galargh rebased, is the issue gone? |
Seems so, I think we're good to go 😁 I'll take the vars in a sec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can set CI_BUILD_RUNS_ON
var to ["self-hosted", "linux", "x64", "2xlarge"]
again.
After we merge it, that var will also affect the persist
job.
Edit I set the variable.
This change produced no new differences in built artifacts. |
This change produced no new differences in built artifacts. |
The goal is to make it faster, this PR aims to test if using self-hosted runner speeds up release build.
If it is ok, we can decide to set CI_BUILD_RUNS_ON on this repo instead.
cc @galargh for sanity check + if we need to safelist this repo somewhere for this to work (i tried to set
CI_BUILD_RUNS_ON
but https://github.com/ipfs/distributions/actions/runs/5799417224/job/15719370344 was stuck waiting for free runner and i cancelled it).