-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ➕ Add pull_request_template to all helia* repos. #182
Conversation
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansipfs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the pr template looks good, but there are a bunch of unrelated changes here too?
Adding the stale.yml
workflow and changing the secret scanning rules on some non-helia repos?
@achingbrain Interesting, I only added 7dd2a90 then a sneaky commit shows up as me: 82363f8 It's unverified, not me, the bot-overlords assumed my identity and pulled these shenanigans. |
Huh, weird - something similar happened in the libp2p/github-mgmt repo the other day. @galargh @laurentsenta can this be prevented from happening? |
I wrote down a longer reply in libp2p/github-mgmt#198. Similarly to that case, here, #181 was left unattended for a while. I filed an issue for commits that are incorrectly associated with real users - ipdxco/github-as-code#110 As for changing the existing behaviour, you could remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, after this is merged, a new PR actually adding the template to all helia repos will get created.
I'm about to archive most of the |
@achingbrain so this should still be merged? Or should wait for the monorepo change? IIUC this can go in independent of that change. |
I would very much like no further commits to be pushed to the repos that are being merged into the main Helia monorepo. |
Alright! @achingbrain I'll merge it once you're ready! Edit: the merge is blocked on your review. Will merge when unblocked |
This should be good to go now! |
I ran https://github.com/ipfs/github-mgmt/actions/workflows/sync.yml to pull in the repo archivisation actions into the state of this repository. |
@lidel @achingbrain do either of you have merge permissions on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved conflicts, merging.
Summary
Adding pull request template for all
helia*
projects.Why do you need this?
For the sake of consistency
DRI: myself
Reviewer's Checklist