-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update benchmark deps and minor fix #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full Bench run with
|
This was referenced Dec 14, 2023
Merged
Note: Applying the below patch to both
diff --git a/node_modules/blockstore-fs/dist/src/index.js b/node_modules/blockstore-fs/dist/src/index.js
index 9fdb295..72a9ca2 100644
--- a/node_modules/blockstore-fs/dist/src/index.js
+++ b/node_modules/blockstore-fs/dist/src/index.js
@@ -13,21 +13,23 @@
*/
import fs from 'node:fs/promises';
import path from 'node:path';
-import { promisify } from 'node:util';
+// import { promisify } from 'node:util';
import { Errors } from 'blockstore-core';
// @ts-expect-error no types
-import fwa from 'fast-write-atomic';
+// import fwa from 'fast-write-atomic';
import glob from 'it-glob';
import map from 'it-map';
import parallelBatch from 'it-parallel-batch';
import { NextToLast } from './sharding.js';
-const writeAtomic = promisify(fwa);
+import {Writer as StenoWriter} from 'steno';
+// const writeAtomic = promisify(fwa);
/**
* Write a file atomically
*/
async function writeFile(file, contents) {
try {
- await writeAtomic(file, contents);
+ const writer = new StenoWriter(file, {flags: 'w'});
+ await writer.write(contents);
}
catch (err) {
if (err.code === 'EPERM' && err.syscall === 'rename') { see ipfs/js-stores#284 for more information |
achingbrain
approved these changes
Dec 30, 2023
achingbrain
changed the title
chore(bench/gc): update deps and minor fix
chore: update benchmark deps and minor fix
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: js-ipfs is disabled for the below runs
Note that applying these changes on top of #231 results in the following: