Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle dnslink pointing to CID with peer id (ipns name) #722

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: handle dnslink pointing to CID with peer id (ipns name) #722

merged 2 commits into from
Jan 24, 2025

Conversation

2color
Copy link
Member

@2color 2color commented Jan 22, 2025 •
edited
Loading

What's in this PR

fixes #721

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@2color 2color requested a review from a team as a code owner January 22, 2025 11:18
@2color 2color force-pushed the fix-dnslink-to-ipns branch from 35a2065 to 6f9076c Compare January 22, 2025 11:19
achingbrain
achingbrain previously requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - can you please add a test to ensure there are no future regressions?

@2color 2color requested a review from achingbrain January 22, 2025 12:12
@2color
Copy link
Member Author

2color commented Jan 23, 2025

Tests are in place

SgtPooki
SgtPooki approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. the test seems legit

@2color 2color changed the title fix: handle dnslink pointing to cid peer id fix: handle dnslink pointing to cid peer id (ipns name) Jan 24, 2025
@2color 2color changed the title fix: handle dnslink pointing to cid peer id (ipns name) fix: handle dnslink pointing to CID with peer id (ipns name) Jan 24, 2025
@2color 2color merged commit 2666d64 into main Jan 24, 2025
22 checks passed
@2color 2color deleted the fix-dnslink-to-ipns branch January 24, 2025 08:58
@achingbrain achingbrain mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPNS cannot resolve DNSLink with ipns public keys
3 participants
@2color @achingbrain @SgtPooki