Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add telemetry #30

Merged
merged 6 commits into from
Jan 26, 2023
Merged

feat: add telemetry #30

merged 6 commits into from
Jan 26, 2023

Conversation

SgtPooki
Copy link
Member

fixes #28

@SgtPooki
Copy link
Member Author

ping @djmcquillan @whizzzkid

@SgtPooki SgtPooki mentioned this pull request Jan 24, 2023
8 tasks
Copy link

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +4 to +5
const telemetry = new BrowserMetricsProvider({ appKey: 'b09437fd68bb257fef9b844a624fac0859b6224e' })
window.telemetry = telemetry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering if this should be hook up automatically when BrowserMetricsProvider is init.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since these are only temporary (removed when #29 is done) I don't think so, but I'm open

@SgtPooki
Copy link
Member Author

@aschmahmann any comments before i merge this? How do we deploy this once merged?

Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SgtPooki not much to add here. Given the nature of the PR someone on your team is probably much better equipped to review than me.

The website itself should be auto-deployed by Fleek when you merge to master (it's managed by a PL account). I think it currently just deploys the "web" folder and doesn't need to do anything special, if that's changed as a function of this PR then you might need to change the Fleek configuration as well.

web/index.html Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SgtPooki SgtPooki self-assigned this Jan 26, 2023
Also use minified telemetry.min.js instead of unminified telemetry.js.

This resolves the need for a build step since ipfs-gui doesn't have
access to the deployment environment.
@SgtPooki SgtPooki removed the request for review from lidel January 26, 2023 19:15
@0xDanomite
Copy link

lgtm with added telemetry.min.js

@SgtPooki SgtPooki merged commit 9702b6f into main Jan 26, 2023
@SgtPooki SgtPooki deleted the feat/add-telemetry branch January 26, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: ignite-metrics - Add telemetry without UI
4 participants