Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helia and js-ipfs stragglers #1639

Merged
merged 8 commits into from
Jul 25, 2023
Merged

Helia and js-ipfs stragglers #1639

merged 8 commits into from
Jul 25, 2023

Conversation

ElPaisano
Copy link
Contributor

Addresses @BigLep unaddressed comments on merged PR 1620. Comments are here #1620 (review)

@ElPaisano ElPaisano linked an issue Jul 24, 2023 that may be closed by this pull request
@ElPaisano
Copy link
Contributor Author

@BigLep I think I've addressed everything in the comments except the issue that https://docs.ipfs.tech/install/js-ipfs/#install-js-ipfs is still documenting js-ipfs and not Helia. I can use the wiki to create a "quickstart" that more or less mirrors the existing flow i.e. install, spawn a node, add a file, etc., what do think? Will change the file name and add redirects.

docs/concepts/faq.md Outdated Show resolved Hide resolved
docs/concepts/faq.md Outdated Show resolved Hide resolved
docs/concepts/faq.md Outdated Show resolved Hide resolved
docs/concepts/faq.md Outdated Show resolved Hide resolved
docs/concepts/faq.md Outdated Show resolved Hide resolved
docs/concepts/faq.md Outdated Show resolved Hide resolved
docs/how-to/publish-ipns.md Outdated Show resolved Hide resolved
@SgtPooki
Copy link
Member

https://docs.ipfs.tech/install/js-ipfs/#install-js-ipfs is still documenting js-ipfs and not Helia. I can use the wiki to create a "quickstart" that more or less mirrors the existing flow i.e. install, spawn a node, add a file, etc., what do think? Will change the file name and add redirects.

Can we point users to helia-examples which will essentially be a living document?

ElPaisano and others added 3 commits July 24, 2023 15:33
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
@ElPaisano
Copy link
Contributor Author

@SgtPooki thanks for getting to the GH action-flagged issues as well as the other issues you caught. The remaining GH action-flagged issues are one false positive for the link check and a vale flag for "IPIPs", so we can ignore. I also went through again and made some more changes.

Can I have you pull this branch down and build the local preview? I'm trying to determine if there is a build error that will cause issues in prod or if its just my local environment. Will explain more if you encounter any local build errors.

@SgtPooki SgtPooki self-requested a review July 24, 2023 23:31
@ElPaisano ElPaisano merged commit c4c343f into main Jul 25, 2023
2 of 5 checks passed
@ElPaisano ElPaisano deleted the js-ipfs/cleanup-2 branch July 25, 2023 00:05
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog and figure out what to do with js-ipfs content
3 participants