chore: update eslint-config-ipfs and fix lint #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SgtPooki
commented
Jun 8, 2023
•
SgtPooki
commented
- Update eslint-config-ipfs.
- Moved app-specific types to types.ts from global.d.ts due to import() type eslint rule violations.
- add type imports where types are needed and used to be globally available.
SgtPooki
force-pushed
the
update-eslint-config-ipfs
branch
from
66b84db
to
6c2f99e
Compare
I don't think it does at all, since this only involves fixing linting issues.. there is zero logic change in this, and practically zero code changes that aren't only moving things from global.d.ts -> types.ts and adding type imports where things used to be globally available.
Updated description |
whizzzkid
approved these changes
Jun 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
## [1.2.2](v1.2.1...v1.2.2) (2023-06-08) ### Trivial Changes * update eslint-config-ipfs and fix lint ([#413](#413)) ([165f35c](165f35c))
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.