Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway: document Retry-After header #435

Merged
merged 1 commit into from
Sep 4, 2023
Merged

gateway: document Retry-After header #435

merged 1 commit into from
Sep 4, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 4, 2023 •
edited
Loading

This is a cosmetic change to Gateway spec that

  • adds missing HTTP 502
    • this is used in projects like Saturn/Rhea for indicating content routing error for requested content path (making it distinct from 504 which is timeout during retrieval phase)
  • adds missing guidance around Retry-After header, which should be leveraged for throttling (429) and in 502 and 504

(We don't need IPIP as this is filling a gap in existing specs to describe production behavior, not adding/changing anything new.)

@lidel lidel mentioned this pull request Sep 4, 2023
Open
willscott
willscott approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having this defined as 'SHOULD' seems very reasonable.

hacdias
hacdias approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable, and better for compliance.

@hacdias hacdias merged commit b3863a6 into main Sep 4, 2023
2 checks passed
@hacdias hacdias deleted the feat/document-retry-after branch September 4, 2023 18:43
rvagg added a commit to filecoin-project/lassie that referenced this pull request Sep 4, 2023
@rvagg
fix: send 502 when no indexer candidates
224f735 
Ref: ipfs/specs#435
@rvagg rvagg mentioned this pull request Sep 4, 2023
Merged
rvagg added a commit to filecoin-project/lassie that referenced this pull request Sep 5, 2023
@rvagg
fix: send 502 when no indexer candidates
13a838a 
Ref: ipfs/specs#435
rvagg added a commit to filecoin-project/lassie that referenced this pull request Sep 8, 2023
@rvagg
fix: send 502 when no indexer candidates
35a886a 
Ref: ipfs/specs#435
rvagg added a commit to filecoin-project/lassie that referenced this pull request Sep 8, 2023
@rvagg
fix: send 502 when no indexer candidates
d82d848 
Ref: ipfs/specs#435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@willscott willscott willscott approved these changes

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
None yet
Projects
No open projects
bifrost-gateway
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidel @willscott @hacdias