Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22 implement abdulelah gani #32

Merged
merged 26 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
41a639b
Well let's see
SalvadorBrandolin Nov 25, 2024
7c0ba5c
keep working tomorrow
SalvadorBrandolin Nov 25, 2024
d075ef0
documentation
SalvadorBrandolin Nov 26, 2024
003d504
little easier frag classes definitions
SalvadorBrandolin Nov 26, 2024
6256dfe
agani primary added, need test
SalvadorBrandolin Nov 26, 2024
5938b26
what a nightmare, need multiple smarts reprs maybe?
SalvadorBrandolin Nov 26, 2024
5497c73
forget to save jupyter
SalvadorBrandolin Nov 26, 2024
44d05e1
erase big file
SalvadorBrandolin Nov 26, 2024
2d573b1
too hard
SalvadorBrandolin Nov 27, 2024
9d0c2ba
keep goiiing
SalvadorBrandolin Nov 28, 2024
77beb71
getting interesting
SalvadorBrandolin Nov 29, 2024
5fa9a99
make me wanna die
SalvadorBrandolin Dec 10, 2024
1334df5
redefinition of agani class, working on secondary structures, error o…
SalvadorBrandolin Dec 16, 2024
1a00bba
lot of work secondary structures, keep working later
SalvadorBrandolin Dec 17, 2024
a35635f
More secondary - structures almost there
SalvadorBrandolin Dec 17, 2024
c258653
almost done - all logp pass, around 100 bugs found, im no't understan…
SalvadorBrandolin Dec 18, 2024
c518dce
now can predict some things
SalvadorBrandolin Dec 19, 2024
d0e1915
properties parameters
SalvadorBrandolin Dec 19, 2024
79351bc
AGani properties calculations and Joback has units now
SalvadorBrandolin Dec 20, 2024
1875e4d
Keep working. Critical temperature works. Need to check for all molec…
SalvadorBrandolin Dec 30, 2024
b1a063f
Pc Vc and w
SalvadorBrandolin Jan 3, 2025
8dcca5a
done testing
SalvadorBrandolin Jan 3, 2025
99f8585
missing: tutorial, fix clapeyron writer
SalvadorBrandolin Jan 3, 2025
6f9090a
Tox pass. Only tutorial missing
SalvadorBrandolin Jan 6, 2025
b69acc0
Tutorial completed
SalvadorBrandolin Jan 6, 2025
23e4ae4
Char error
SalvadorBrandolin Jan 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ libraries:


# Example of use
You can check the full tutorial
[here](https://ipqa-research.github.io/ugropy/tutorial/tutorial.html).
Here is a little taste of `ugropy`, please, check the full tutorial
[here](https://ipqa-research.github.io/ugropy/tutorial/tutorial.html) to see
all it has to offer!

Get groups from the molecule's name:

Expand All @@ -54,11 +55,13 @@ hexane = Groups("hexane")
print(hexane.unifac.subgroups)
print(hexane.psrk.subgroups)
print(hexane.joback.subgroups)
print(hexane.agani.primary.subgroups)
```

{'CH3': 2, 'CH2': 4}
{'CH3': 2, 'CH2': 4}
{'-CH3': 2, '-CH2-': 4}
{'CH3': 2, 'CH2': 4}

Get groups from molecule's SMILES:

Expand All @@ -68,13 +71,15 @@ propanol = Groups("CCCO", "smiles")
print(propanol.unifac.subgroups)
print(propanol.psrk.subgroups)
print(propanol.joback.subgroups)
print(propanol.agani.primary.subgroups)
```

{'CH3': 1, 'CH2': 2, 'OH': 1}
{'CH3': 1, 'CH2': 2, 'OH': 1}
{'-CH3': 1, '-CH2-': 2, '-OH (alcohol)': 1}
{'CH3': 1, 'CH2': 2, 'OH': 1}

Estimate properties with the Joback model!
Estimate properties with the Joback and Abdulelah-Gani models!

```python
limonene = Groups("limonene")
Expand All @@ -85,9 +90,23 @@ print(f"{limonene.joback.vapor_pressure(176 + 273.15)} bar")
```

{'-CH3': 2, '=CH2': 1, '=C<': 1, 'ring-CH2-': 3, 'ring>CH-': 1, 'ring=CH-': 1, 'ring=C<': 1}
657.4486692170663 K
657.4486692170663 kelvin
1.0254019428522743 bar

```python
print(limonene.agani.primary.subgroups)
print(limonene.agani.secondary.subgroups)
print(limonene.agani.tertiary.subgroups)
print(f"{limonene.agani.critical_temperature}")
print(limonene.agani.molecular_weight / limonene.agani.liquid_molar_volume)
```

{'CH3': 2, 'CH2=C': 1, 'CH2 (cyclic)': 3, 'CH (cyclic)': 1, 'CH=C (cyclic)': 1}
{'CH3-CHm=CHn (m,n in 0..2)': 1, '(CHn=C)cyc-CH3 (n in 0..2)': 1, 'CHcyc-C=CHn (n in 1..2)': 1}
{}
640.1457030826214 kelvin
834.8700605718585 gram / liter

Visualize your results! (The next code creates the `ugropy` logo)

```Python
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani Class
====================

.. automodule:: ugropy.core.frag_classes.abdulelah_gani.abdulelah_gani
:members:
:undoc-members:
:show-inheritance:
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani PST Class
========================

.. automodule:: ugropy.core.frag_classes.abdulelah_gani.abdulelah_gani_pst
:members:
:undoc-members:
:show-inheritance:
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani PST Result
=========================

.. automodule:: ugropy.core.frag_classes.abdulelah_gani.abdulelah_gani_pst_result
:members:
:undoc-members:
:show-inheritance:
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani Result Class
===========================

.. automodule:: ugropy.core.frag_classes.abdulelah_gani.abdulelah_gani_result
:members:
:undoc-members:
:show-inheritance:
15 changes: 15 additions & 0 deletions docs/source/core/frag_classes/abdulelah_gani/init.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Abdulelah-Gani fragmentation Classes
====================================

.. automodule:: ugropy.core.frag_classes.abdulelah_gani
:members:
:undoc-members:
:show-inheritance:

.. toctree::
:maxdepth: 1

abdulelah_gani_pst_result
abdulelah_gani_pst
abdulelah_gani_result
abdulelah_gani
1 change: 1 addition & 0 deletions docs/source/core/frag_classes/init.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ Fragmentation Classes
base/init
gibbs_model/init
joback_model/init
abdulelah_gani/init
7 changes: 7 additions & 0 deletions docs/source/models/abdulelah_gani_mod.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani Model
====================

.. automodule:: ugropy.models.abdulelah_gani_mod
:members:
:undoc-members:
:show-inheritance:
7 changes: 7 additions & 0 deletions docs/source/models/abdulelah_gani_pmod.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani Primary Model
============================

.. automodule:: ugropy.models.abdulelah_gani_pmod
:members:
:undoc-members:
:show-inheritance:
7 changes: 7 additions & 0 deletions docs/source/models/abdulelah_gani_smod.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani Secondary Model
==============================

.. automodule:: ugropy.models.abdulelah_gani_smod
:members:
:undoc-members:
:show-inheritance:
7 changes: 7 additions & 0 deletions docs/source/models/abdulelah_gani_tmod.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Abdulelah-Gani Tertiary Model
=============================

.. automodule:: ugropy.models.abdulelah_gani_tmod
:members:
:undoc-members:
:show-inheritance:
4 changes: 4 additions & 0 deletions docs/source/models/init.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ Models
.. toctree::
:maxdepth: 1

abdulelah_gani_mod
abdulelah_gani_pmod
abdulelah_gani_smod
abdulelah_gani_tmod
jobackmod
psrkmod
unifacmod
17 changes: 17 additions & 0 deletions docs/source/refs.bib
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
@article{gani,
title = {Next generation pure component property estimation models: {With} and without machine learning techniques},
volume = {68},
issn = {0001-1541, 1547-5905},
shorttitle = {Next generation pure component property estimation models},
url = {https://aiche.onlinelibrary.wiley.com/doi/10.1002/aic.17469},
doi = {10.1002/aic.17469},
language = {en},
number = {6},
urldate = {2023-10-24},
journal = {AIChE Journal},
author = {Alshehri, Abdulelah S. and Tula, Anjan K. and You, Fengqi and Gani, Rafiqul},
month = jun,
year = {2022},
pages = {e17469},
}

@misc{ddbst,
author = {},
title = {{P}ublished {P}arameters {U}{N}{I}{F}{A}{C} - {D}{D}{B}{S}{T} {G}mb{H} --- ddbst.com},
Expand Down
6 changes: 3 additions & 3 deletions docs/source/tutorial/database/critical.csv
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Clapeyron Database File,,,,,
Critical Single Parameters,,,,,
species,CAS,Tc,Pc,Vc,acentricfactor
limonene,,657.4486692170663,2755561.066677689,0.0004965,0.3219127551737521
adrenaline,,953.7486693594541,5569169.079973267,0.0004115,1.6071531017924205
Trinitrotoluene,,1146.7095578060987,4067315.701790919,0.0005654999999999999,1.0796561474496789
limonene,,657.4486692170663,2755561.066677689,0.0004965000000000001,0.3219127551737521
adrenaline,,953.7486693594541,5569169.079973267,0.0004115000000000001,1.6071531017924205
Trinitrotoluene,,1146.7095578060987,4067315.701790919,0.0005655000000000001,1.0796561474496789
Loading
Loading