Fix/php8 (#866)

* first commit * fix calculate numeric grades --------- Co-authored-by: gabriel-IPTI <ti.gabriel@ipti.org.br>
ipti · Nov 6, 2024 · efd3696 · efd3696
1 parent b694401
commit efd3696
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/domain/grades/usecases/CalculateNumericGradeUsecase.php b/app/domain/grades/usecases/CalculateNumericGradeUsecase.php
@@ -285,6 +285,9 @@ private function calculateFinalRecoveryMedia($enrollment, $disciplineId, $unity)
     private function applyStrategyComputeGradesByFormula($calculation, $unityOrRecovery, $grades, $isRecovery)
     {
         $result = 0;
+
+        if(empty($grades)){ return 0; }
+
         switch ($calculation) {
             default:
             case 'Soma':

diff --git a/app/modules/courseplan/controllers/CourseplanController.php b/app/modules/courseplan/controllers/CourseplanController.php
@@ -289,9 +289,10 @@ public function actionSave($id = null)
                     TLog::info("Aula salva com sucesso", ['CourseClassId' => $courseClass->id, 'CoursePlanId' => $coursePlan->id]);
                 }
 
-                array_push($courseClassIds, $courseClass->id);
+                $courseClassIds[] = $courseClass->id;
 
-                CourseClassHasClassAbility::model()->deleteAll("course_class_fk = :course_class_fk and course_class_ability_fk not in ( '" . implode("', '", $cc['ability']) . "' )", [":course_class_fk" => $courseClass->id]);
+                $abilitiesMerged = is_array($cc['ability']) ? implode("', '", $cc['ability']): $cc['ability'];
+                CourseClassHasClassAbility::model()->deleteAll("course_class_fk = :course_class_fk and course_class_ability_fk not in ( '" . $abilitiesMerged . "' )", [":course_class_fk" => $courseClass->id]);
                 foreach ($cc["ability"] as $abilityId) {
                     $courseClassHasClassAbility = CourseClassHasClassAbility::model()->find("course_class_fk = :course_class_fk and course_class_ability_fk = :course_class_ability_fk", ["course_class_fk" => $courseClass->id, "course_class_ability_fk" => $abilityId]);
                     if ($courseClassHasClassAbility == null) {