rust: ensure encoded/decoded strings are ASCII #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stopgap until the issue of Unicode normalization can be properly addressed (e.g. should we check strings are NFC or NFD?) Furthermore, the `unicode-normalization` crate doesn't support `no_std` environments (sans liballoc yet): unicode-rs/unicode-normalization#58 Ensuring all strings are ASCII, while perhaps overly restrictive for now, will ensure all documents produced today are canonical in a way that's forward compatible with canonical Unicode.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stopgap until the issue of Unicode normalization can be properly addressed (e.g. should we check strings are NFC or NFD?)
Furthermore, the
unicode-normalizationcrate doesn't supportno_stdenvironments (sans liballoc yet):unicode-rs/unicode-normalization#58
Ensuring all strings are ASCII, while perhaps overly restrictive for now, will ensure all documents produced today are canonical in a way that's forward compatible with canonical Unicode.